[PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855

[PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855

[Harald Welte]

The south bridge of the VIA VX855 chipset has a different PCI Device ID
so i2c-viapro.c needs to be updated with this.

Signed-off-by: Harald Welte <HaraldWelte-yS34VQbMlVtBDgjK7y7TUQ@public.gmane.org>
---
 drivers/i2c/busses/i2c-viapro.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
index 02e6f72..7a0b15a 100644
--- a/drivers/i2c/busses/i2c-viapro.c
+++ b/drivers/i2c/busses/i2c-viapro.c
@@ -37,6 +37,7 @@
    VT8251             0x3287             yes
    CX700              0x8324             yes
    VX800/VX820        0x8353             yes
+   VX855/VX875        0x8409             yes
 
    Note: we assume there can only be one device, with one SMBus interface.
 */
@@ -469,6 +470,8 @@ static struct pci_device_id vt596_ids[] = {
 	  .driver_data = SMBBA3 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800),
 	  .driver_data = SMBBA3 },
+	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855),
+	  .driver_data = SMBBA3 },
 	{ 0, }
 };
 
-- 
1.6.2.4

Re: [PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855

[Jean Delvare]

Hi Harald,

On Sun, 17 May 2009 14:04:39 +0800, Harald Welte wrote:
> The south bridge of the VIA VX855 chipset has a different PCI Device ID
> so i2c-viapro.c needs to be updated with this.
> 
> Signed-off-by: Harald Welte <HaraldWelte-yS34VQbMlVtBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-viapro.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
> index 02e6f72..7a0b15a 100644
> --- a/drivers/i2c/busses/i2c-viapro.c
> +++ b/drivers/i2c/busses/i2c-viapro.c
> @@ -37,6 +37,7 @@
>     VT8251             0x3287             yes
>     CX700              0x8324             yes
>     VX800/VX820        0x8353             yes
> +   VX855/VX875        0x8409             yes
>  
>     Note: we assume there can only be one device, with one SMBus interface.
>  */
> @@ -469,6 +470,8 @@ static struct pci_device_id vt596_ids[] = {
>  	  .driver_data = SMBBA3 },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800),
>  	  .driver_data = SMBBA3 },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855),
> +	  .driver_data = SMBBA3 },
>  	{ 0, }
>  };
>  

Thanks for your contribution. You did not include
PCI_DEVICE_ID_VIA_VX855 to the list of devices which support I2C block
transactions (in function vt596_probe), is this on purpose or an
overlook?

-- 
Jean Delvare

Re: [PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855

[Harald Welte]

Hi Jean,

On Sun, May 17, 2009 at 10:19:52AM +0200, Jean Delvare wrote:

> Thanks for your contribution. You did not include
> PCI_DEVICE_ID_VIA_VX855 to the list of devices which support I2C block
> transactions (in function vt596_probe), is this on purpose or an
> overlook?

it was an overlook on my side, sorry.  Can you just add that yourself or do you wnat me to send another patch?

-- 
- Harald Welte <HaraldWelte-yS34VQbMlVtBDgjK7y7TUQ@public.gmane.org>	    http://linux.via.com.tw/
============================================================================
VIA Open Source Liaison

Re: [PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855

[Jean Delvare]

On Sun, 17 May 2009 20:59:40 +0800, Harald Welte wrote:
> On Sun, May 17, 2009 at 10:19:52AM +0200, Jean Delvare wrote:
> 
> > Thanks for your contribution. You did not include
> > PCI_DEVICE_ID_VIA_VX855 to the list of devices which support I2C block
> > transactions (in function vt596_probe), is this on purpose or an
> > overlook?
> 
> it was an overlook on my side, sorry.  Can you just add that yourself or
> do you wnat me to send another patch?

I'll add it myself, no problem.

-- 
Jean Delvare