From: Rodolfo Giometti <giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Subject: Re: [PATCH] i2c: Limit core locking to the necessary sections
Date: Tue, 19 May 2009 08:51:42 +0200 [thread overview]
Message-ID: <20090519065141.GA9809@enneenne.com> (raw)
In-Reply-To: <20090514210436.45171424-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Thu, May 14, 2009 at 09:04:36PM +0200, Jean Delvare wrote:
> The i2c-core code tends to hold the core lock for longer than it
> should. Limit locking to the necessary sections for both performance
> and clarity. This is also a requirement to support I2C multiplexers in
> the future.
These seem ok to me. :)
> Testing was successful on my system but I would love to hear from other
> testers. This kind of thing is easy to get wrong.
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org>
> Cc: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
> ---
> Rodolfo, this should solve the deadlocks you had been encountering
> while working on I2C multiplexing support. I would like you to give a
Yes it does.
> try to my current stack of i2c patches:
> ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c.tar.gz
>
> If it works OK, please rebase your multiplexing patches on top of it.
> Then I'll review them. I'd like to have initial multiplexing support in
> kernel 2.6.31, which doesn't leave us too much time.
Sorry for the long delay in reply but I was very busy in these
days... however I'll try to give a test at whole patchset ASAP!
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
next prev parent reply other threads:[~2009-05-19 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 19:04 [PATCH] i2c: Limit core locking to the necessary sections Jean Delvare
[not found] ` <20090514210436.45171424-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-05-19 6:51 ` Rodolfo Giometti [this message]
2009-06-03 16:42 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519065141.GA9809@enneenne.com \
--to=giometti-avvdyk/kqijwk0htik3j/w@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).