From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller Date: Mon, 1 Jun 2009 06:43:30 +0300 Message-ID: <20090601034329.GD14148@tarshish> References: <1242725005-6431-1-git-send-email-baruch@tkos.co.il> <63386a3d0905271223k470bb89elbbb566b68c0d7cd7@mail.gmail.com> <20090528041051.GB4855@tarshish> <63386a3d0905280032x7f427213t2b9b027d5be2a472@mail.gmail.com> <20090531052345.GB14148@tarshish> <63386a3d0905311147h5a92bb3cy6659db914acd476e@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <63386a3d0905311147h5a92bb3cy6659db914acd476e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks List-Id: linux-i2c@vger.kernel.org Hi Linus, On Sun, May 31, 2009 at 08:47:31PM +0200, Linus Walleij wrote: > 2009/5/31 Baruch Siach : > > On Thu, May 28, 2009 at 09:32:37AM +0200, Linus Walleij wrote: > >> 2009/5/28 Baruch Siach : > >> > >> >> > +static int dw_i2c_probe(struct platform_device *pdev) > >> >> > >> >> Can you tag this with __init? > >> > > >> > OK. __devinit is probably better. > >> > >> I don't think any platform_device tagged with __devinit is > >> correct really, platform_device:s cannot =A0be hotplugged that's > >> against the definition of a platform_device. > > > > Doesn't this __devinit have something to do with the ability to com= pile the > > driver as a module (as is the case here)? See for example > > drivers/watchdog/omap_wdt.c and commit > > 0e3912c75f42986c17d955542247bf04c6eef738 >=20 > ... > > In practice this means that if you device is _NOT_ hot-pluggable, the > kernel will still nevertheless keep all the code in __devinit and > __devexit around which means that __devinit code cannot be > free:ed after init and it increases the footprint of your kernel for = no > good reason. Thanks for your detailed explanation. I'll go for __init then. baruch --=20 ~. .~ Tk Open Sy= stems =3D}------------------------------------------------ooO--U--Ooo--------= ----{=3D - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -