linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller
Date: Sat, 13 Jun 2009 10:28:20 +0100	[thread overview]
Message-ID: <20090613092820.GC20446@fluff.org.uk> (raw)
In-Reply-To: <1243398392-1516-1-git-send-email-baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>

Notes:

1) failed to fix resource_size()
2) No explanation over use of static in loop

Please sort these out and post a new patch.

-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

  parent reply	other threads:[~2009-06-13  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19  9:23 [PATCH] i2c: driver for the Synopsys DesignWare I2C controller Baruch Siach
     [not found] ` <1242725005-6431-1-git-send-email-baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2009-05-26 21:39   ` Ben Dooks
     [not found]     ` <20090526213917.GH23114-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-05-27  4:26       ` Baruch Siach
     [not found]         ` <1243398392-1516-1-git-send-email-baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2009-06-13  9:28           ` Ben Dooks [this message]
2009-05-27 19:23   ` Linus Walleij
     [not found]     ` <63386a3d0905271223k470bb89elbbb566b68c0d7cd7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-28  4:10       ` Baruch Siach
2009-05-28  7:32         ` Linus Walleij
     [not found]           ` <63386a3d0905280032x7f427213t2b9b027d5be2a472-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-31  5:23             ` Baruch Siach
2009-05-31 18:47               ` Linus Walleij
     [not found]                 ` <63386a3d0905311147h5a92bb3cy6659db914acd476e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-01  3:43                   ` Baruch Siach
2009-06-01 22:53               ` Ben Dooks
     [not found]                 ` <20090601225354.GB18453-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-02  6:57                   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090613092820.GC20446@fluff.org.uk \
    --to=ben-linux-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
    --cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).