From: Felipe Balbi <me@felipebalbi.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "me@felipebalbi.com" <me@felipebalbi.com>,
"Krishnamoorthy, Balaji T" <balajitk@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"david-b@pacbell.net" <david-b@pacbell.net>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"sameo@openedhand.com" <sameo@openedhand.com>,
"wim@iguana.be" <wim@iguana.be>,
"timo.t.kokkonen@nokia.com" <timo.t.kokkonen@nokia.com>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Nayak, Rajendra" <rnayak@ti.com>
Subject: Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use
Date: Tue, 21 Jul 2009 08:24:48 +0300 [thread overview]
Message-ID: <20090721052447.GA13013@gandalf> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02B59502D7@dbde02.ent.ti.com>
hi,
On Tue, Jul 21, 2009 at 10:01:06AM +0530, Shilimkar, Santosh wrote:
> > So IMO, renaming the files is unnecessary.
> Well tps* are just catalog names of the twl4* family. So you can keep adding whatever names there as long it's a same IC.
>
> Perhaps you look in hurry to comment about this. Please look at the intention of these patches. TWL6030 has PM IC similar to TWL4030 with bit different interrupt management. Audio IC is a separate one as compared to combined in case of TWL4030.
>
> If it allows code re-use by renaming files, it should be good. Isn't it ?
What I'm trying to say is you can re-use the code even without renaming
those files, just add twl6030-irq and use some sort of runtime check to
use one or other irq mechanism.
--
balbi
next prev parent reply other threads:[~2009-07-21 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 13:31 [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use balajitk-l0cyMroinI0
2009-07-20 18:52 ` Felipe Balbi
2009-07-21 4:31 ` Shilimkar, Santosh
2009-07-21 5:24 ` Felipe Balbi [this message]
2009-07-21 5:33 ` Shilimkar, Santosh
2009-07-22 14:54 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721052447.GA13013@gandalf \
--to=me@felipebalbi.com \
--cc=balajitk@ti.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=rnayak@ti.com \
--cc=sameo@openedhand.com \
--cc=santosh.shilimkar@ti.com \
--cc=timo.t.kokkonen@nokia.com \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).