From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c: Do not give adapters a default parent Date: Tue, 28 Jul 2009 14:47:55 +0200 Message-ID: <20090728144755.69d328d4@hyperion.delvare> References: <20090426103025.4525edd3@hyperion.delvare> <20090504124341.42405e79@hyperion.delvare> <20090704191431.3d352d0b@hyperion.delvare> <20090705225616.1d4817e7@hyperion.delvare> <20090722210753.35802816@hyperion.delvare> <1248296688.2065.4.camel@yio.site> <20090723160259.78a10e37@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kay Sievers Cc: Linux I2C , Greg KH List-Id: linux-i2c@vger.kernel.org Hi Kay, On Thu, 23 Jul 2009 17:19:22 +0200, Kay Sievers wrote: > On Thu, Jul 23, 2009 at 16:02, Jean Delvare wrote= : > > I don't think you need the "return" here, as sysfs_remove_link retu= rns > > void. >=20 > Fixed. Thanks. What's the merge timeline for this patch? > > Other than that (and in practice even with that) your patch works j= ust > > fine for me. Thanks! Unfortunately it doesn't provide perfect > > compatibility, [...] to add this device link (pointing to "..") tem= porarily > > or would that be too confusing? >=20 > I think that's ok, if it solves a real problem. The entire idea of _a= _ > "device" link is pretty flawed, and the reason we ripped all the > "struct class_device" devices out. OK, I've added the "device" link and now compatibility works perfectly. I'll post the updated patch series soon, if you want to take a look. Would it make sense to move the "device" link creation into class_compat_create_link()? I suspect other users of a compatibility class may need it as well. > > Another thing we have to discuss is the compatibility option. For n= ow > > I've made it i2c-specific and enabled by default: > > > > config I2C_COMPAT > > =A0 =A0 =A0 =A0boolean "Enable compatibility bits for old user-spac= e" > > =A0 =A0 =A0 =A0default y > > =A0 =A0 =A0 =A0help > > =A0 =A0 =A0 =A0 =A0Say Y here if you intend to run lm-sensors 3.1.1= or older. > > > > But this means a lot of ifdefs in my code (6). With a system-wide > > option, we could provide empty stubs I could get rid of them. OTOH,= It > > is easier to control the lifetime, and change the default value, of= a > > subsystem specific option. So I'm not too sure what do to. >=20 > I'm not sure too. I think it's fine to have it per-subsytem, as only > the subsystem knows for how long it is needed, and it can probably be > dropped some day. OK, fine with me. --=20 Jean Delvare