From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: balajitk@ti.com, linux-omap@vger.kernel.org,
khilman@deeprootsystems.com, david-b@pacbell.net,
linux-i2c@vger.kernel.org, sameo@openedhand.com, wim@iguana.be,
timo.t.kokkonen@nokia.com, ben-linux@fluff.org,
lrg@slimlogic.co.uk, Rajendra Nayak <rnayak@ti.com>
Subject: Re: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators
Date: Tue, 4 Aug 2009 10:45:45 +0300 [thread overview]
Message-ID: <20090804074544.GG24334@atomide.com> (raw)
In-Reply-To: <20090803142356.GA4265@rakim.wolfsonmicro.main>
* Mark Brown <broonie@opensource.wolfsonmicro.com> [090803 17:23]:
> On Wed, Jul 29, 2009 at 10:06:13AM +0530, balajitk@ti.com wrote:
>
> > - if (twl_has_regulator()) {
> > + if (twl_has_regulator() && is_class_twl4030()) {
>
> is_class_twl4030() feels like it should have better namespacing, though
> having the part name in there means it's not actually an issue.
How about twl_is_4030()?
> > @@ -306,6 +306,7 @@ int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> > #define TWL4030_INT_PWR_EDR2 0x6
> > #define TWL4030_INT_PWR_SIH_CTRL 0x7
> >
> > +
> > /*----------------------------------------------------------------------*/
> >
> > /* Power bus message definitions */
>
> Random unrelated indentation change?
next prev parent reply other threads:[~2009-08-04 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 4:36 [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators balajitk
[not found] ` <1248842173-21821-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org>
2009-08-03 14:23 ` Mark Brown
2009-08-04 7:45 ` Tony Lindgren [this message]
[not found] ` <20090804074544.GG24334-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2009-08-04 7:56 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02B5CD8884-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-04 8:16 ` Krishnamoorthy, Balaji T
2009-08-04 13:24 ` Premi, Sanjeev
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB59301D8BD1708-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-04 13:26 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02B5CD8BFF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-04 13:42 ` Mark Brown
[not found] ` <20090804134247.GA32353-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2009-08-04 13:58 ` Shilimkar, Santosh
2009-08-05 21:39 ` Mark Brown
[not found] ` <20090805213932.GD20853-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2009-08-06 7:27 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02B5D8155B-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-06 8:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804074544.GG24334@atomide.com \
--to=tony@atomide.com \
--cc=balajitk@ti.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=rnayak@ti.com \
--cc=sameo@openedhand.com \
--cc=timo.t.kokkonen@nokia.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).