From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: "Shilimkar, Santosh" <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
Cc: "Premi, Sanjeev" <premi-l0cyMroinI0@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Krishnamoorthy,
Balaji T" <balajitk-l0cyMroinI0@public.gmane.org>,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org"
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
"david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org"
<david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"sameo-RWuK6r/cQWRpLGFMi4vTTA@public.gmane.org"
<sameo-RWuK6r/cQWRpLGFMi4vTTA@public.gmane.org>,
"wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org"
<wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
"timo.t.kokkonen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org"
<timo.t.kokkonen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
"ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org"
<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
"lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org"
<lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
"Nayak, Rajendra" <rnayak-l0cyMroinI0@public.gmane.org>
Subject: Re: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators
Date: Tue, 4 Aug 2009 14:42:48 +0100 [thread overview]
Message-ID: <20090804134247.GA32353@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02B5CD8BFF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
On Tue, Aug 04, 2009 at 06:56:13PM +0530, Shilimkar, Santosh wrote:
> > > > is_class_twl4030() feels like it should have better namespacing,
> > though
> > > > having the part name in there means it's not actually an issue.
> > > How about twl_is_4030()?
> > The idea was to have a class of twl4030 IC's type IC's. There are many of
> > them with just different name (TPS *)
> > ... twl_class_is_4030().... What you say ?
> > Can I suggest: pmic_class_is_xxx() ?
> Even better
That feels like it's got a more global namespace than it ought - this is
really only for this class of chip. It's also got a bit of an
assumption that there's only one PMIC in the system which isn't always
the case.
next prev parent reply other threads:[~2009-08-04 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 4:36 [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators balajitk
[not found] ` <1248842173-21821-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org>
2009-08-03 14:23 ` Mark Brown
2009-08-04 7:45 ` Tony Lindgren
[not found] ` <20090804074544.GG24334-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2009-08-04 7:56 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02B5CD8884-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-04 8:16 ` Krishnamoorthy, Balaji T
2009-08-04 13:24 ` Premi, Sanjeev
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB59301D8BD1708-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-04 13:26 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02B5CD8BFF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-04 13:42 ` Mark Brown [this message]
[not found] ` <20090804134247.GA32353-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2009-08-04 13:58 ` Shilimkar, Santosh
2009-08-05 21:39 ` Mark Brown
[not found] ` <20090805213932.GD20853-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2009-08-06 7:27 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02B5D8155B-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-06 8:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804134247.GA32353@rakim.wolfsonmicro.main \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=balajitk-l0cyMroinI0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=premi-l0cyMroinI0@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=sameo-RWuK6r/cQWRpLGFMi4vTTA@public.gmane.org \
--cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \
--cc=timo.t.kokkonen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).