From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators Date: Thu, 6 Aug 2009 09:11:34 +0100 Message-ID: <20090806081133.GA6438@rakim.wolfsonmicro.main> References: <1248842173-21821-1-git-send-email-balajitk@ti.com> <20090803142356.GA4265@rakim.wolfsonmicro.main> <20090804074544.GG24334@atomide.com> <20090804134247.GA32353@rakim.wolfsonmicro.main> <20090805213932.GD20853@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Shilimkar, Santosh" Cc: "Premi, Sanjeev" , Tony Lindgren , "Krishnamoorthy, Balaji T" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org" , "david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "sameo-RWuK6r/cQWRpLGFMi4vTTA@public.gmane.org" , "wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org" , "timo.t.kokkonen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org" , "ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org" , "lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "Nayak, Rajendra" List-Id: linux-i2c@vger.kernel.org On Thu, Aug 06, 2009 at 12:57:26PM +0530, Shilimkar, Santosh wrote: > So what you suggest here. Some of the earlier names like twl_is_*() seemed OK; given that the driver is called twl everywhere I don't see much problem with the tps variants using that scheme too.