* Re: [PATCH 2/8] Regulator: Adding header file for TPS65023
[not found] ` <20090807155558.GJ639@sirena.org.uk>
@ 2009-08-07 20:25 ` Felipe Balbi
0 siblings, 0 replies; only message in thread
From: Felipe Balbi @ 2009-08-07 20:25 UTC (permalink / raw)
To: ext Mark Brown
Cc: Anuj Aggarwal, lrg@slimlogic.co.uk, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c
On Fri, Aug 07, 2009 at 05:55:58PM +0200, ext Mark Brown wrote:
> On Fri, Aug 07, 2009 at 08:55:36PM +0530, Anuj Aggarwal wrote:
>
> This is OK but since you'll need to resubmit anyway it might be nice to
> consider moving the register & bitfield definitions into the driver file
> since they can't be used by any other code.
>
> > +/* DCDC's */
>
> Extra ' here :)
I agree, there shouldn't be need for this file.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
^ permalink raw reply [flat|nested] only message in thread