From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Anuj Aggarwal <anuj.aggarwal-l0cyMroinI0@public.gmane.org>
Cc: lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv2 2/3] Regulator: Add TPS6507x regulator driver
Date: Thu, 20 Aug 2009 19:38:18 +0100 [thread overview]
Message-ID: <20090820183817.GA5032@sirena.org.uk> (raw)
In-Reply-To: <1250776230-18245-1-git-send-email-anuj.aggarwal-l0cyMroinI0@public.gmane.org>
On Thu, Aug 20, 2009 at 07:20:30PM +0530, Anuj Aggarwal wrote:
One very minor issue:
> +struct tps_pmic {
> + struct regulator_desc desc[TPS6507X_NUM_REGULATOR];
> + struct i2c_client *client;
> + struct regulator_dev *rdev[TPS6507X_NUM_REGULATOR];
> + struct tps_info *info[TPS6507X_NUM_REGULATOR];
This should be const struct tps_info * since the table of tps_info
structs that this points into is const; otherwise you'll get warnings
from at least sparse.
Otherwise this looks good - I'd be happy to ack this with a followup
patch fixing this issue.
prev parent reply other threads:[~2009-08-20 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 13:50 [PATCHv2 2/3] Regulator: Add TPS6507x regulator driver Anuj Aggarwal
[not found] ` <1250776230-18245-1-git-send-email-anuj.aggarwal-l0cyMroinI0@public.gmane.org>
2009-08-20 18:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820183817.GA5032@sirena.org.uk \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=anuj.aggarwal-l0cyMroinI0@public.gmane.org \
--cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).