From: Chaitanya Lala <clala-DUeqMYwuH4dWk0Htik3J/w@public.gmane.org>
To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [linux-2.6 PATCH 1/1] i2c-i801: Re-read busy bit and wait for transaction to complete
Date: Wed, 26 Aug 2009 15:11:05 -0700 [thread overview]
Message-ID: <20090826221105.GA19712@clala-laptop> (raw)
Intel ESB2 SMBus chip seems to have an issue where it momentarily
resets the HOST_BUSY bit in the host status register. This confuses
the driver waiting for an SMBus transaction to complete. This patch
adds a workaround for the same.
Signed-off-by: Chaitanya Lala <clala-DUeqMYwuH4dWk0Htik3J/w@public.gmane.org>
---
drivers/i2c/busses/i2c-i801.c | 23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 9d2c5ad..1a04817 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -222,6 +222,7 @@ static int i801_transaction(int xact)
int status;
int result;
int timeout = 0;
+ int counter = 0;
result = i801_check_pre();
if (result < 0)
@@ -231,12 +232,34 @@ static int i801_transaction(int xact)
* INTREN, SMBSCMD are passed in xact */
outb_p(xact | I801_START, SMBHSTCNT);
+try_again:
/* We will always wait for a fraction of a second! */
do {
msleep(1);
status = inb_p(SMBHSTSTS);
} while ((status & SMBHSTSTS_HOST_BUSY) && (timeout++ < MAX_TIMEOUT));
+ /* The i801 chip resets the HOST_BUSY bit
+ * to indicate that it has completed the transaction,
+ * but a moment later sets it again. Seems like a glitch.
+ * Changed code to check the value more times if its not a timeout.
+ */
+ if (timeout < MAX_TIMEOUT) {
+ msleep(1);
+ status = inb_p(SMBHSTSTS);
+ if (status & SMBHSTSTS_HOST_BUSY) {
+ dev_warn(&I801_dev->dev, "Busy bit set again"
+ "(%02x)\n", status);
+ if (++counter < 3) {
+ dev_info(&I801_dev->dev, "Trying"
+ "again\n");
+ goto try_again;
+ }
+ dev_err(&I801_dev->dev, "No use"
+ " retrying-(%02x)\n", status);
+ }
+ }
+
result = i801_check_post(status, timeout > MAX_TIMEOUT);
if (result < 0)
return result;
--
1.6.0.4
next reply other threads:[~2009-08-26 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 22:11 Chaitanya Lala [this message]
2009-09-12 19:38 ` [linux-2.6 PATCH 1/1] i2c-i801: Re-read busy bit and wait for transaction to complete Jean Delvare
[not found] ` <20090912213843.59e990ad-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-15 17:34 ` Chaitanya Lala
[not found] ` <4AAFD040.6040702-DUeqMYwuH4dWk0Htik3J/w@public.gmane.org>
2009-09-15 18:40 ` Jean Delvare
[not found] ` <20090915204032.30dbfffe-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-15 19:00 ` Chaitanya Lala
[not found] ` <4AAFE438.60308-DUeqMYwuH4dWk0Htik3J/w@public.gmane.org>
2009-12-17 13:21 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826221105.GA19712@clala-laptop \
--to=clala-dueqmywuh4dwk0htik3j/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).