* [PATCH] i2c/scx200_acb: Provide more information on bus errors
@ 2009-08-29 19:18 Jean Delvare
0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2009-08-29 19:18 UTC (permalink / raw)
To: Linux I2C; +Cc: Willy Tarreau
From: Willy Tarreau <wtarreau-w2o5dE7VsCkiY7fawQvujQ@public.gmane.org>
Upon a bus error, it's rather hard to guess what happened. Dumping the
address, length and status provides a lot of value for troubleshooting
issues.
Signed-off-by: Willy Tarreau <wtarreau-w2o5dE7VsCkiY7fawQvujQ@public.gmane.org>
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
drivers/i2c/busses/scx200_acb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- linux-2.6.31-rc8.orig/drivers/i2c/busses/scx200_acb.c 2009-06-10 05:05:27.000000000 +0200
+++ linux-2.6.31-rc8/drivers/i2c/busses/scx200_acb.c 2009-08-29 20:44:33.000000000 +0200
@@ -217,8 +217,10 @@ static void scx200_acb_machine(struct sc
return;
error:
- dev_err(&iface->adapter.dev, "%s in state %s\n", errmsg,
- scx200_acb_state_name[iface->state]);
+ dev_err(&iface->adapter.dev,
+ "%s in state %s (addr=0x%02x, len=%d, status=0x%02x)\n", errmsg,
+ scx200_acb_state_name[iface->state], iface->address_byte,
+ iface->len, status);
iface->state = state_idle;
iface->result = -EIO;
--
Jean Delvare
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-08-29 19:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-29 19:18 [PATCH] i2c/scx200_acb: Provide more information on bus errors Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).