Re: [PATCH] I2C: add driver for SMBus Control Method Interface

[Crane Cai <crane.cai-5C7GfCeVMHo@public.gmane.org>]

Hi Jean,

On Wed, Sep 09, 2009 at 06:04:31PM +0200, Jean Delvare wrote:
> Hi Crane,
> 
> On Thu, 27 Aug 2009 10:29:58 +0800, Crane Cai wrote:
> > This driver supports the SMBus Control Method Interface. It needs BIOS declare
> > ACPI control methods via SMBus Control Method Interface Spec.
> > http://smbus.org/specs/smbus_cmi10.pdf
> > 
> > Hi Jean,
> > This driver can give BIOS a chance to avoid SMBus access conflicts on runtime.
> > And it obeys the SMBus CMI spec.
> > Please apply.
> 
> This is very interesting. Do you happen to have, or know, systems which
> actually implement this? Were you able to test your code?
Till now I only know our internal BIOS implement this control method. 
The code has been tested.
> 
> How can I check if any of my systems do implement this?
Now BIOS team give us an option to let these control methods exported.
> 
> Full review below, inline. I had many comments but they are really
> small things, overall your code is very good and getting the driver in
> shape for 2.6.32 seems totally feasible.
Thanks, these comments are very important to me. I will rework my code on them
and retest and resubmit a new version. It needs some days.
> 

-- 
Best Regards,
- Crane