From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Richard Zhao <linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] i2c: imx: check busy bit when START/STOP
Date: Tue, 29 Sep 2009 15:24:41 +0100 [thread overview]
Message-ID: <20090929142440.GF32420@sirena.org.uk> (raw)
In-Reply-To: <4e090d470909290654r6fb36cb4h505662c7cb84b1f8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Sep 29, 2009 at 09:54:05PM +0800, Richard Zhao wrote:
> On Tue, Sep 29, 2009 at 9:25 PM, Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> > I think it's generally a good idea to start/stop the clocks when needed
> > as you do here. It should be an extra patch though.
> You think I should split the patch to three: IBB, reg_dump, clk dis/en ?
> The idea is good, more easy to revert. but sometimes, I think it make
> small things too complex.
Keeping small things simple is half the reason for doing this - it's not
just bisection, it's also the fact that it's much easier to read and
understand a small patch that does one thing than it is to do the same
with a large patch which makes several unrelated changes. When several
changes are lumped in together it's harder to see the complete version
of any one change in isolation and more effort is required to work out
which goals are being accomplished with any given chunk of the patch.
next prev parent reply other threads:[~2009-09-29 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 11:41 [PATCH] i2c: imx: check busy bit when START/STOP Richard Zhao
[not found] ` <4e090d470909290441i7016c4f4g9a929d78838f9b7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-29 13:09 ` Wolfram Sang
2009-09-29 13:25 ` Sascha Hauer
2009-09-29 13:54 ` Richard Zhao
[not found] ` <4e090d470909290654r6fb36cb4h505662c7cb84b1f8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-29 14:06 ` Sascha Hauer
[not found] ` <20090929140612.GN27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-09-29 23:21 ` Richard Zhao
2009-09-29 14:24 ` Mark Brown [this message]
[not found] ` <20090929142440.GF32420-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-09-29 15:14 ` Richard Zhao
-- strict thread matches above, loose matches on Subject: below --
2009-09-30 5:47 Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929142440.GF32420@sirena.org.uk \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).