From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Jean Delvare <khali@linux-fr.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH] ltc4215/ltc4245: Discard obsolete detect methods
Date: Wed, 7 Oct 2009 08:18:48 -0700 [thread overview]
Message-ID: <20091007151847.GA8496@ovro.caltech.edu> (raw)
In-Reply-To: <20090920151627.76dd424e@hyperion.delvare>
On Sun, Sep 20, 2009 at 03:16:27PM +0200, Jean Delvare wrote:
> There is no point in implementing a detect callback for the LTC4215
> and LTC4245, as these devices can't be detected. It was there solely
> to handle "force" module parameters to instantiate devices, but now
> we have a better sysfs interface that can do the same.
>
> So we can get rid of the ugly module parameters and the detect
> callbacks. This shrinks the binary module sizes by 36% and 46%,
> respectively.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Ira W. Snyder <iws@ovro.caltech.edu>
> ---
> Ira, can you please test and confirm it works OK for you?
>
I've finally gotten around to testing this. I applied it to 2.6.31.2.
Testing shows no problems at all. The devices are both automatically
bound by the OF device tree, just like before.
You've got my ACK.
Ira
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-10-07 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 13:16 [PATCH] ltc4215/ltc4245: Discard obsolete detect methods Jean Delvare
2009-10-07 15:18 ` Ira W. Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007151847.GA8496@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).