From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ira W. Snyder" Subject: Re: [PATCH] ltc4215/ltc4245: Discard obsolete detect methods Date: Wed, 7 Oct 2009 08:18:48 -0700 Message-ID: <20091007151847.GA8496@ovro.caltech.edu> References: <20090920151627.76dd424e@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20090920151627.76dd424e@hyperion.delvare> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: lm-sensors-bounces@lm-sensors.org Errors-To: lm-sensors-bounces@lm-sensors.org To: Jean Delvare Cc: Linux I2C , LM Sensors List-Id: linux-i2c@vger.kernel.org On Sun, Sep 20, 2009 at 03:16:27PM +0200, Jean Delvare wrote: > There is no point in implementing a detect callback for the LTC4215 > and LTC4245, as these devices can't be detected. It was there solely > to handle "force" module parameters to instantiate devices, but now > we have a better sysfs interface that can do the same. > > So we can get rid of the ugly module parameters and the detect > callbacks. This shrinks the binary module sizes by 36% and 46%, > respectively. > > Signed-off-by: Jean Delvare > Cc: Ira W. Snyder > --- > Ira, can you please test and confirm it works OK for you? > I've finally gotten around to testing this. I applied it to 2.6.31.2. Testing shows no problems at all. The devices are both automatically bound by the OF device tree, just like before. You've got my ACK. Ira _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors