From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH 1/2] i2c-powermac: Refactor i2c_powermac_smbus_xfer
Date: Thu, 22 Oct 2009 15:25:28 +0200 [thread overview]
Message-ID: <20091022152528.45e24f3d@hyperion.delvare> (raw)
In-Reply-To: <1255215931.2192.11.camel@pasglop>
Hi Ben,
On Sun, 11 Oct 2009 10:05:31 +1100, Benjamin Herrenschmidt wrote:
> On Sat, 2009-10-10 at 14:19 +0200, Jean Delvare wrote:
> > I wanted to add some error logging to the i2c-powermac driver, but
> > found that it was very difficult due to the way the
> > i2c_powermac_smbus_xfer function is organized. Refactor the code in
> > this function so that each low-level function is only called once.
> >
> > Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> > Cc: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> > Cc: Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> > ---
> > This needs testing! Thanks.
>
> Ok, will give it a go next week.
Did you finally find some time to test my i2c-powermac patches?
Thanks,
--
Jean Delvare
prev parent reply other threads:[~2009-10-22 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 12:19 [PATCH 1/2] i2c-powermac: Refactor i2c_powermac_smbus_xfer Jean Delvare
[not found] ` <20091010141908.0be884a5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-10-10 23:05 ` Benjamin Herrenschmidt
2009-10-22 13:25 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022152528.45e24f3d@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox