From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Crane Cai <crane.cai@amd.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
lenb@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] acpi: support IBM SMBus CMI devices
Date: Mon, 26 Oct 2009 13:53:41 -0700 [thread overview]
Message-ID: <20091026205341.GQ26149@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20091025125353.55d3bfad@hyperion.delvare>
On Sun, Oct 25, 2009 at 12:53:53PM +0100, Jean Delvare wrote:
> > + else if (!probe_ibm_smbus_device(device))
> > + acpi_add_id(device, ACPI_SMBUS_IBM_HID);
>
> I am not responsible for the ACPI code, but... wouldn't it make sense
> to rename probe_ibm_smbus_device() to acpi_ibm_smbus_match() and have
> it follow the same convention as acpi_dock_match() and
> acpi_bay_match()? To make the code more consistent.
Sure.
> > + {ACPI_SMBUS_IBM_HID, (kernel_ulong_t)&ibm_smbus_methods},
>
> As both patches depend on each other and one is useless without the
> other, you might as well sequence them the other way around, so that
> you touch this line only once.
Will do.
> Other that these details, I like the patch. If this helps with ACPI
> resource conflicts, even better :)
It should. :) I'll reroll the patch set shortly.
--D
next prev parent reply other threads:[~2009-10-26 20:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 23:11 [PATCH] i2c-scmi: Quirk to work on IBM machines with broken BIOSes Darrick J. Wong
2009-10-21 2:30 ` Crane Cai
2009-10-21 14:57 ` Bjorn Helgaas
[not found] ` <200910210857.13978.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2009-10-21 17:37 ` Darrick J. Wong
2009-10-22 7:17 ` Crane Cai
2009-10-22 17:43 ` Darrick J. Wong
2009-10-22 18:37 ` Jean Delvare
2009-10-23 4:44 ` Crane Cai
2009-10-23 17:03 ` [PATCH 1/2] i2c-scmi: support IBM SMBus CMI devices Darrick J. Wong
[not found] ` <20091023170306.GP26149-bjhdApgbSaxhsM67afOH+sxtgHpCUUYS@public.gmane.org>
2009-10-25 9:39 ` Jean Delvare
[not found] ` <20091025103932.31ce9a6d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-10-26 2:54 ` Crane Cai
2009-10-23 17:03 ` [PATCH 2/2] acpi: " Darrick J. Wong
2009-10-25 11:53 ` Jean Delvare
2009-10-26 20:53 ` Darrick J. Wong [this message]
2009-10-26 20:58 ` [PATCH v2 1/2] " Darrick J. Wong
2009-10-27 17:03 ` Jean Delvare
2009-10-27 17:30 ` Darrick J. Wong
[not found] ` <20091027173001.GT26149-bjhdApgbSaxhsM67afOH+sxtgHpCUUYS@public.gmane.org>
2009-10-27 17:36 ` Jean Delvare
2009-12-04 17:06 ` Darrick J. Wong
[not found] ` <20091204170621.GA10356-bjhdApgbSaxhsM67afOH+sxtgHpCUUYS@public.gmane.org>
2009-12-04 17:36 ` Bjorn Helgaas
[not found] ` <200912041036.36686.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2009-12-04 18:07 ` Darrick J. Wong
2009-12-04 18:11 ` [RESEND PATCH v2 1/2] ACPI: Quirk to make SMBus objects work on IBM machines with broken BIOSes Darrick J. Wong
2009-12-17 14:02 ` Jean Delvare
2010-01-05 12:30 ` Jean Delvare
2009-12-04 18:13 ` [RESEND PATCH v2 2/2] i2c-scmi: support IBM SMBus CMI devices Darrick J. Wong
2009-10-26 21:00 ` [PATCH " Darrick J. Wong
2009-10-27 17:24 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026205341.GQ26149@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=bjorn.helgaas@hp.com \
--cc=crane.cai@amd.com \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).