From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [PATCH v2 1/2] acpi: support IBM SMBus CMI devices Date: Tue, 27 Oct 2009 10:30:01 -0700 Message-ID: <20091027173001.GT26149@tux1.beaverton.ibm.com> References: <20091021023016.GC32413@crane-desktop> <200910210857.13978.bjorn.helgaas@hp.com> <20091021173733.GN26149@tux1.beaverton.ibm.com> <20091022071748.GA17917@crane-desktop> <20091022174304.GO26149@tux1.beaverton.ibm.com> <20091023044451.GB1367@crane-desktop> <20091023170311.GC21723@tux1.beaverton.ibm.com> <20091025125353.55d3bfad@hyperion.delvare> <20091026205819.GR26149@tux1.beaverton.ibm.com> <20091027180332.62f2c758@hyperion.delvare> Reply-To: djwong@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20091027180332.62f2c758@hyperion.delvare> Sender: linux-acpi-owner@vger.kernel.org To: Jean Delvare Cc: Crane Cai , Bjorn Helgaas , lenb@kernel.org, linux-kernel , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On Tue, Oct 27, 2009 at 06:03:32PM +0100, Jean Delvare wrote: > I'm only half please with this. You change the function named, but it > doesn't follow the calling convention of acpi_dock_match(), which is a > little confusing. > > Anyway, I will need an ack from the ACPI people before I can pick this > patch. Or maybe they should even push it upstream themselves. I am confused. Looking at that bunch of ifs, acpi_is_video_device returns 1 for a match and 0 for no match. acpi_bay_match returns 0 for a match and -ENODEV for no match, which just happens to work with the ACPI_SUCCESS macro. acpi_dock_match returns ACPI error codes. Each of the three existing tests has different return value semantics, so it is not clear to me which one I should use. I didn't think it was correct for my probe function to use the ACPI_STATUS macro unless it returned ACPI error codes... which it does not. -ENODEV seemed appropriate for "no device found". Is it desirable to clean them all up to follow the same convention? --D