From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 1/1] Remove suspend/resume functionality, add dynamic clocking Date: Thu, 26 Nov 2009 10:02:52 +0100 Message-ID: <20091126090252.GB12179@pengutronix.de> References: <083DF309106F364B939360100EC290F804F55C9225@eu1rdcrdc1wx030.exi.nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <083DF309106F364B939360100EC290F804F55C9225-SIPbe8o7cfX8DdpCu65jn8FrZmdRls4ZQQ4Iyu8u01E@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kevin Wells Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Russell King - ARM Linux , Vitaly Wool List-Id: linux-i2c@vger.kernel.org Hello, can you please add something like "i2c-pnx: " to the subject? (Actually it's a great strategy *not* to put it into the Subject. This way it attracts far more attention :-) > Remove suspend/resume functionality, I2C driver gates clock on > only when an I2C transaction is in progress What happens when the machine suspends while a transfer is in progress? (This might be a problem that already existed before.) If this is really a problem the easiest "fix" is to let the suspend callback retur= n -EBUSY in this case. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.= de/ |