From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Sven Anders <anders-3bOZC6EutKuELgA04lAiVw@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Need help: Watchdog-driver over smbus (i2c)
Date: Thu, 3 Dec 2009 23:17:02 +0100 [thread overview]
Message-ID: <20091203231702.039106c5@hyperion.delvare> (raw)
In-Reply-To: <4B18261B.8070507-3bOZC6EutKuELgA04lAiVw@public.gmane.org>
On Thu, 03 Dec 2009 21:56:59 +0100, Sven Anders wrote:
> Jean Delvare schrieb:
> > Hallo Sven,
> >
> > On Mon, 30 Nov 2009 22:30:07 +0100, Sven Anders wrote:
> >
> >> Moreover the w83793g hardware sensors driver may already
> >> accessing the same chip. What is the normal way to deal with this?
> >
> > Do not write a separate driver for the watchdog functionality. Instead,
> > add the functionality to the existing hwmon/w83793.c driver. Otherwise
> > both features will be mutually exclusive.
> >
> > An example of how this can be done is in hwmon/fschmd.c [1] if you want
> > to take a look. This is an I2C/SMBus device driver as well, so your code
> > should be very similar in the end.
> >
> > [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/hwmon/fschmd.c
> >
> > Hope this helps,
>
> Yes, thanks! This was the hint I needed.
> Now I finished the watchdog driver and it's working!
Cool. When it's ready, please send it over to the lm-sensors list so
that it gets merged.
--
Jean Delvare
prev parent reply other threads:[~2009-12-03 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 21:30 Need help: Watchdog-driver over smbus (i2c) Sven Anders
[not found] ` <4B14395F.4070608-3bOZC6EutKuELgA04lAiVw@public.gmane.org>
2009-12-01 9:31 ` Jean Delvare
[not found] ` <20091201103120.6ba0f7e0-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-12-03 20:56 ` Sven Anders
[not found] ` <4B18261B.8070507-3bOZC6EutKuELgA04lAiVw@public.gmane.org>
2009-12-03 22:17 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203231702.039106c5@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=anders-3bOZC6EutKuELgA04lAiVw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).