[PATCH] pca953x: Minor include cleanup

[PATCH] pca953x: Minor include cleanup

[Olof Johansson]

linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
includes of linux/i2c/pca953x.h, and add dependent includes into the
header file.

Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

diff --git a/include/linux/i2c/pca953x.h b/include/linux/i2c/pca953x.h
index 81736d6..29699f8 100644
--- a/include/linux/i2c/pca953x.h
+++ b/include/linux/i2c/pca953x.h
@@ -1,3 +1,9 @@
+#ifndef _LINUX_PCA953X_H
+#define _LINUX_PCA953X_H
+
+#include <linux/types.h>
+#include <linux/i2c.h>
+
 /* platform data for the PCA9539 16-bit I/O expander driver */
 
 struct pca953x_platform_data {
@@ -17,3 +23,5 @@ struct pca953x_platform_data {
 				void *context);
 	char		**names;
 };
+
+#endif /* _LINUX_PCA953X_H */

Re: [PATCH] pca953x: Minor include cleanup

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

On Tue, Jan 05, 2010 at 02:10:42PM -0600, Olof Johansson wrote:
> linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
> includes of linux/i2c/pca953x.h, and add dependent includes into the
> header file.
> 
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] pca953x: Minor include cleanup

[Jean Delvare]

On Tue, 5 Jan 2010 21:21:58 +0100, Wolfram Sang wrote:
> On Tue, Jan 05, 2010 at 02:10:42PM -0600, Olof Johansson wrote:
> > linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
> > includes of linux/i2c/pca953x.h, and add dependent includes into the
> > header file.
> > 
> > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> 
> Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

And also

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

Note though that this file is not part of the i2c subsystem. Your patch
is something for the gpio people.

-- 
Jean Delvare

Re: [PATCH] pca953x: Minor include cleanup

[Olof Johansson]

On Wed, Jan 06, 2010 at 12:17:22PM +0100, Jean Delvare wrote:
> On Tue, 5 Jan 2010 21:21:58 +0100, Wolfram Sang wrote:
> > On Tue, Jan 05, 2010 at 02:10:42PM -0600, Olof Johansson wrote:
> > > linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
> > > includes of linux/i2c/pca953x.h, and add dependent includes into the
> > > header file.
> > > 
> > > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> > 
> > Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> 
> And also
> 
> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> 
> Note though that this file is not part of the i2c subsystem. Your patch
> is something for the gpio people.

Boggle. No GPIO maintianer (nor list) mentioned in MAINTAINERS. I
don't see any common merge paths in the git log of drivers/gpio either,
besides akpm.

So I guess I'll ask him to pick it up.

Andrew: Want a fresh copy of the patch?


-Olof

Re: [PATCH] pca953x: Minor include cleanup

[Jean Delvare]

Hi Olof,

On Fri, 8 Jan 2010 15:34:15 -0600, Olof Johansson wrote:
> Boggle. No GPIO maintianer (nor list) mentioned in MAINTAINERS. I
> don't see any common merge paths in the git log of drivers/gpio either,
> besides akpm.

Correct. Feel free to step in ;)

-- 
Jean Delvare