Re: [PATCH] i2c: make PCI device id constant

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Márton,

On Sun, 10 Jan 2010 15:33:08 +0100, Németh Márton wrote:
> From: Márton Németh <nm127-Y8qEzhMunLyT9ig0jae3mg@public.gmane.org>
> 
> The id_table field of the struct pci_driver is constant in <linux/pci.h>
> so it is worth to make initialization data also constant.
> 
> The semantic match that finds this kind of pattern is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> disable decl_init,const_decl_init;
> identifier I1, I2, x;
> @@
> 	struct I1 {
> 	  ...
> 	  const struct I2 *x;
> 	  ...
> 	};
> @s@
> identifier r.I1, y;
> identifier r.x, E;
> @@
> 	struct I1 y = {
> 	  .x = E,
> 	};
> @c@
> identifier r.I2;
> identifier s.E;
> @@
> 	const struct I2 E[] = ... ;
> @depends on !c@
> identifier r.I2;
> identifier s.E;
> @@
> +	const
> 	struct I2 E[] = ...;
> // </smpl>
> 
> Signed-off-by: Márton Németh <nm127-Y8qEzhMunLyT9ig0jae3mg@public.gmane.org>
> Cc: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
> Cc: cocci-dAYI7NvHqcQ@public.gmane.org
> ---

Applied, thanks.

-- 
Jean Delvare