From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Seth Heasley <seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org
Subject: Re: [PATCH 2.6.32.3] i2c-i801: SMBus patch for Intel Cougar Point DeviceIDs
Date: Tue, 19 Jan 2010 12:00:40 +0100 [thread overview]
Message-ID: <20100119120040.14444393@hyperion.delvare> (raw)
In-Reply-To: <201001121658.54044.seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Seth,
Please note that the i2c mailing list address has changed.
On Tue, 12 Jan 2010 16:58:53 -0800, Seth Heasley wrote:
> This patch adds the Intel Cougar Point (PCH) SMBus Controller DeviceIDs.
This comment suggests that Cougar Point == PCH, while the comments in
i2c-i801 suggests otherwise. Who is right?
>
> Signed-off-by: Seth Heasley <seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> --- linux-2.6.32.3/drivers/i2c/busses/i2c-i801.c.orig 2010-01-06 15:07:45.000000000 -0800
> +++ linux-2.6.32.3/drivers/i2c/busses/i2c-i801.c 2010-01-07 13:10:28.000000000 -0800
> @@ -41,7 +41,8 @@
> Tolapai 0x5032 32 hard yes yes yes
> ICH10 0x3a30 32 hard yes yes yes
> ICH10 0x3a60 32 hard yes yes yes
> - PCH 0x3b30 32 hard yes yes yes
> + 3400/5 Series (PCH) 0x3b30 32 hard yes yes yes
> + CPT 0x1c22 32 hard yes yes yes
>
> Features supported by this driver:
> Software PEC no
> @@ -578,6 +579,7 @@
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_4) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_5) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PCH_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CPT_SMBUS) },
> { 0, }
> };
>
> @@ -707,6 +709,7 @@
> case PCI_DEVICE_ID_INTEL_ICH10_4:
> case PCI_DEVICE_ID_INTEL_ICH10_5:
> case PCI_DEVICE_ID_INTEL_PCH_SMBUS:
> + case PCI_DEVICE_ID_INTEL_CPT_SMBUS:
> i801_features |= FEATURE_I2C_BLOCK_READ;
> /* fall through */
> case PCI_DEVICE_ID_INTEL_82801DB_3:
> --- linux-2.6.32.3/drivers/i2c/busses/Kconfig.orig 2010-01-06 15:07:45.000000000 -0800
> +++ linux-2.6.32.3/drivers/i2c/busses/Kconfig 2010-01-07 13:10:28.000000000 -0800
> @@ -98,6 +98,7 @@
> Tolapai
> ICH10
> PCH
> + CPT
It might be clear for you that "CPT" means "Cougar Point", but for the
reader it may not be. I'd rather list the full chip name. Same in
i2c-i801.c's header comment, BTW.
>
> This driver can also be built as a module. If so, the module
> will be called i2c-i801.
Documentation/i2c/busses/i2c-i801 needs to be updated as well.
--
Jean Delvare
parent reply other threads:[~2010-01-19 11:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201001121658.54044.seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119120040.14444393@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).