From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Valentin Longchamp <valentin.longchamp-p8DiymsW2f8@public.gmane.org>
Cc: s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mxc i2c: let time to generate stop bit
Date: Thu, 21 Jan 2010 12:42:16 +0100 [thread overview]
Message-ID: <20100121114216.GA3738@pengutronix.de> (raw)
In-Reply-To: <1264073263-16374-1-git-send-email-valentin.longchamp-p8DiymsW2f8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Thu, Jan 21, 2010 at 12:27:43PM +0100, Valentin Longchamp wrote:
> After generating the stop bit by changing MSTA from 1 to 0,
> the i2c_imx->stopped was immediatly set to 1. The second test
> on i2c_imx->stopped then is correct and the controller never
> waits if the bus is busy. This patch corrects this.
>
> On mx31moboard, stop bit was not generated on single write transfers.
> This was kept unnoticed other transfers are made afterwards that
> help the write recipient to resynchronize.
"as other transfers"?
> Thanks to Philippe and Michael for the debugging.
Either full names, or maybe even Reported-by or Tested-by tags?
> Signed-off-by: Valentin Longchamp <valentin.longchamp-p8DiymsW2f8@public.gmane.org>
Patch itself looks good to me:
Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-01-21 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 11:27 [PATCH] mxc i2c: let time to generate stop bit Valentin Longchamp
[not found] ` <1264073263-16374-1-git-send-email-valentin.longchamp-p8DiymsW2f8@public.gmane.org>
2010-01-21 11:42 ` Wolfram Sang [this message]
[not found] ` <20100121114216.GA3738-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-01-21 17:55 ` Valentin Longchamp
[not found] ` <1264096532-23580-1-git-send-email-valentin.longchamp-p8DiymsW2f8@public.gmane.org>
2010-01-21 18:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121114216.GA3738@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=valentin.longchamp-p8DiymsW2f8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox