From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH RESEND 1/1] i2c: Add support for Xilinx XPS IIC Bus Interface Date: Sun, 24 Jan 2010 19:54:46 +0100 Message-ID: <20100124195446.2268fd20@hyperion.delvare> References: <4B55D74C.2010806@pelagicore.com> <20100124154930.GE28675@fluff.org.uk> <4B5C8460.2040309@pelagicore.com> <20100124181526.GB25641@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100124181526.GB25641-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Richard =?UTF-8?B?UsO2amZvcnM=?= , Ben Dooks , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton List-Id: linux-i2c@vger.kernel.org On Sun, 24 Jan 2010 19:15:26 +0100, Wolfram Sang wrote: > > >> + * i2c-xiic.c > > > > > > the directory path to the file would have been nice. > > > > Will update > > Ben, are you sure? Those filenames (especially with directories) easily go > stale when reorganizing the tree. FWIW, I agree with Wolfram on that. Embedding the path in the header comment of a file doesn't add any value. -- Jean Delvare