From: Jean-Hugues Deschenes <jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
Jean-Hugues Deschenes
<jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH v3 2/3] i2c-designware: Check component type register
Date: Wed, 27 Jan 2010 14:19:51 -0500 [thread overview]
Message-ID: <20100127191949.759985000@octasic.com> (raw)
In-Reply-To: 20100127191949.575931000@octasic.com
[-- Attachment #1: check_dw_component --]
[-- Type: text/plain, Size: 1666 bytes --]
Designware component type register is checked before attaching to the device.
Signed-off-by: Jean-Hugues Deschenes <jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-designware.c | 11 +++++++++++
1 file changed, 11 insertions(+)
Index: linux-2.6_i2c/drivers/i2c/busses/i2c-designware.c
===================================================================
--- linux-2.6_i2c.orig/drivers/i2c/busses/i2c-designware.c
+++ linux-2.6_i2c/drivers/i2c/busses/i2c-designware.c
@@ -68,6 +68,7 @@
#define DW_IC_TXFLR 0x74
#define DW_IC_RXFLR 0x78
#define DW_IC_COMP_PARAM_1 0xf4
+#define DW_IC_COMP_TYPE 0xfc
#define DW_IC_TX_ABRT_SOURCE 0x80
#define DW_IC_CON_MASTER 0x1
@@ -709,6 +710,7 @@ static int __devinit dw_i2c_probe(struct
struct i2c_adapter *adap;
struct resource *mem, *ioarea;
int irq, r;
+ u32 reg;
/* NOTE: driver uses the static register mapping */
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -755,12 +757,19 @@ static int __devinit dw_i2c_probe(struct
r = -EBUSY;
goto err_unuse_clocks;
}
- {
- u32 param1 = dw_readl(dev, DW_IC_COMP_PARAM_1);
- dev->tx_fifo_depth = ((param1 >> 16) & 0xff) + 1;
- dev->rx_fifo_depth = ((param1 >> 8) & 0xff) + 1;
+ reg = dw_readl(dev, DW_IC_COMP_TYPE);
+ if (reg != 0x44570140) {
+ dev_err(&pdev->dev, "Unknown Synopsys component type: "
+ "0x%08x\n", reg);
+ r = -ENODEV;
+ goto err_iounmap;
}
+
+ reg = dw_readl(dev, DW_IC_COMP_PARAM_1);
+ dev->tx_fifo_depth = ((reg >> 16) & 0xff) + 1;
+ dev->rx_fifo_depth = ((reg >> 8) & 0xff) + 1;
+
i2c_dw_init(dev);
dw_writel(dev, 0, DW_IC_INTR_MASK); /* disable IRQ */
--
next prev parent reply other threads:[~2010-01-27 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 19:19 [PATCH v3 0/3] i2c-designware: Allow mixed endianness Jean-Hugues Deschenes
2010-01-27 19:19 ` [PATCH v3 1/3] i2c-designware: Use local version of readl & writel Jean-Hugues Deschenes
2010-01-27 19:19 ` Jean-Hugues Deschenes [this message]
2010-01-27 19:19 ` [PATCH v3 3/3] i2c-designware: Allow mixed endianness accesses Jean-Hugues Deschenes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127191949.759985000@octasic.com \
--to=jean-hugues.deschenes-ygvykhu+fedbdgjk7y7tuq@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).