From: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: Hook up runtime PM support
Date: Mon, 15 Feb 2010 20:08:24 +0100 [thread overview]
Message-ID: <201002152008.24142.rjw@sisk.pl> (raw)
In-Reply-To: <20100215183058.GA24590-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
On Monday 15 February 2010, Mark Brown wrote:
> On Mon, Feb 15, 2010 at 07:14:09PM +0100, Jean Delvare wrote:
>
> > Applied, thanks. I am a little surprised to see that these functions
> > have nothing i2c-specific, so I am wondering why we have to duplicate
> > them in every bus type... Shouldn't the functions above be part of
> > drivers/base/power/runtime.c and exported so that all bus types that
> > want them can reuse them?
In fact this is the first bus type that doesn't need anything specific in these
routines so fat.
> I tend to agree - in fact I'd been a little surprised the default for
> buses that don't provide anything was to refuse to do runtime PM (though
> I can see the transition issues when a bus does want to go and do its
> own thing).
>
> My actual plan here was to implement this for a couple of buses and then
> present a patch factoring out the common code.
That's a good approach IMO.
Rafael
next prev parent reply other threads:[~2010-02-15 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 12:30 [PATCH] i2c: Hook up runtime PM support Mark Brown
[not found] ` <1265373011-12874-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2010-02-07 11:45 ` Rafael J. Wysocki
2010-02-15 18:14 ` Jean Delvare
[not found] ` <20100215191409.14d87257-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-02-15 18:30 ` Mark Brown
[not found] ` <20100215183058.GA24590-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-02-15 19:08 ` Rafael J. Wysocki [this message]
[not found] ` <201002152008.24142.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-15 19:14 ` Jean Delvare
2010-02-15 19:15 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-02-03 13:22 Mark Brown
[not found] ` <1265203367-21344-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2010-02-04 21:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002152008.24142.rjw@sisk.pl \
--to=rjw-kkrjlpt3xs0@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).