From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
Subject: Re: [PATCH] i2c: Build core and algo drivers with -Wshadow
Date: Tue, 16 Feb 2010 21:27:15 +0100 [thread overview]
Message-ID: <20100216202715.GC17428@pengutronix.de> (raw)
In-Reply-To: <20100216122152.29dbbeb5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Tue, Feb 16, 2010 at 12:21:52PM +0100, Jean Delvare wrote:
> I like building with -Wshadow, it helps catch bugs or at least bad
> choices in variable names.
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
> Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> Any objection?
[After some searching]
Do you know if -Wshadow has improved since this thread?
http://kerneltrap.org/node/7434
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-02-16 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 11:21 [PATCH] i2c: Build core and algo drivers with -Wshadow Jean Delvare
[not found] ` <20100216122152.29dbbeb5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-02-16 20:27 ` Wolfram Sang [this message]
[not found] ` <20100216202715.GC17428-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-16 21:53 ` Jean Delvare
[not found] ` <20100216225352.1c4c3893-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-02-17 13:35 ` Wolfram Sang
2010-02-17 13:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216202715.GC17428@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).