From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Felix Rubinstein
<felixru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Oleg Ryjkov <oryjkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Seth Heasley
<seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i2c-i801: Don't use the block buffer for I2C block writes
Date: Thu, 4 Mar 2010 11:16:44 +0100 [thread overview]
Message-ID: <20100304111644.62761ee9@hyperion.delvare> (raw)
In-Reply-To: <20100304100917.GB18304-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Thu, 4 Mar 2010 11:09:17 +0100, Wolfram Sang wrote:
> > + /* Experience has shown that the block buffer can only be used for
> > + SMBus (not I2C) block transactions, even though the datasheet
> > + doesn't mention this limitation. */
>
> Minor: Comment style?
checkpatch did not complain, and I couldn't find any consistency in
comment style in this driver.
--
Jean Delvare
prev parent reply other threads:[~2010-03-04 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 10:01 [PATCH] i2c-i801: Don't use the block buffer for I2C block writes Jean Delvare
[not found] ` <20100304110109.541b846e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-04 10:09 ` Wolfram Sang
[not found] ` <20100304100917.GB18304-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-04 10:16 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304111644.62761ee9@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=felixru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oryjkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).