From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Yang Shi <yang.shi-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Konstantin Lazarev
<klazarev-rphTv4pjVZMJGwgDXS7ZQA@public.gmane.org>
Subject: Re: [PATCH] MIPS: Octeon: Register EEPROM device on the I2C bus
Date: Fri, 5 Mar 2010 09:50:40 +0100 [thread overview]
Message-ID: <20100305095040.6ab4612c@hyperion.delvare> (raw)
In-Reply-To: <4B90B888.6060005-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Hi Yang, Wolfram,
On Fri, 05 Mar 2010 15:53:44 +0800, Yang Shi wrote:
> Wolfram Sang 写道:
> >>> Is the use of 'eeprom' instead of 'at24' intentional?
> >>>
> >>>
> >> Unfortunately, at24 driver can't work on this board, I must use legacy
> >> eeprom.
> >>
> >
> > Well, you are of course free to choose here :)
> >
> > I'd just be interested if there is a software limitation which prevents you from
> > using AT24. Because, it _should_ work with all kind of eeproms the legacy driver
> > deals with. Otherwise it is probably a bug which needs to be fixed.
> >
>
> Thanks to point out this. Let me take a look at this.
One limitation of the at24 driver is that it needs the underlying
controller to support either raw I2C access or at least I2C block
transactions. Konstantin Lazarev complained about that one month ago
already.
I am currently working on improving the at24 driver so that it falls
back to byte transactions when block transactions are not available. I
might also add word transaction support (as the eeprom driver has) as
it is often the best performance/compatibility trade-off. I'll post the
patch when I'm done.
I'm not yet sure what will happen to the legacy eeprom driver in the
long run, but I would prefer new designs to not rely on it.
--
Jean Delvare
next prev parent reply other threads:[~2010-03-05 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 7:08 [PATCH] MIPS: Octeon: Register EEPROM device on the I2C bus Yang Shi
[not found] ` <1267772895-25409-1-git-send-email-yang.shi-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-05 7:11 ` Wolfram Sang
[not found] ` <20100305071130.GB21925-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-05 7:31 ` Yang Shi
[not found] ` <4B90B341.9000601-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-05 7:41 ` Wolfram Sang
[not found] ` <20100305074155.GD21925-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-05 7:53 ` Yang Shi
[not found] ` <4B90B888.6060005-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-05 8:50 ` Jean Delvare [this message]
[not found] ` <20100305095040.6ab4612c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-05 10:09 ` Michael Lawnick
[not found] ` <4B90D85E.6040308-Mmb7MZpHnFY@public.gmane.org>
2010-03-05 10:39 ` Yang Shi
[not found] ` <4B90DF48.50005-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-05 10:52 ` Jean Delvare
[not found] ` <4B90E83A.5020106@gmx.de>
[not found] ` <4B90E83A.5020106-Mmb7MZpHnFY@public.gmane.org>
2010-03-05 11:42 ` Jean Delvare
[not found] ` <20100305124200.6f6eccfc-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-05 12:15 ` Michael Lawnick
2010-03-08 4:43 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305095040.6ab4612c@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=klazarev-rphTv4pjVZMJGwgDXS7ZQA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=yang.shi-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).