Re: [PATCH] misc/eeprom/at24: init dynamic bin_attribute structures

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Hi Jean,

> > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> > index 88c20da..d2deea4 100644
> > --- a/drivers/misc/eeprom/at24.c
> > +++ b/drivers/misc/eeprom/at24.c
> > @@ -541,6 +541,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
> >  	at24->bin.attr.mode = chip.flags & AT24_FLAG_IRUGO ? S_IRUGO : S_IRUSR;
> >  	at24->bin.read = at24_bin_read;
> >  	at24->bin.size = chip.byte_len;
> > +	sysfs_bin_attr_init(&at24->bin);
> 
> I think it would make more sense to move the initialization _before_
> manually setting other struct members. You don't know what
> sysfs_bin_attr_init does or will do in the future.

Okay.

> I presume the at25 driver needs the same fix?

Yes, sent it to the SPI-list sperately. I wasn't sure if a patch series would
ease or complicate things.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]