From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Jean-Michel Hautbois <jhautbois-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH]I2C device - release cleanup
Date: Tue, 23 Mar 2010 17:21:43 +0100 [thread overview]
Message-ID: <20100323172143.6b078b2e@hyperion.delvare> (raw)
In-Reply-To: <0016e6d64c23d0770e0482776d51-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Tue, 23 Mar 2010 13:02:41 +0000, jhautbois-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> Hi Jean,
>
> < snip >
> > Did you test your patch? I am very skeptical that calling
>
> > single_release() out of the blue is the right thing to do. My instinct
>
> > tells me that single_release() is only meant for callers of
>
> > single_open().
>
> Well, using this call works fine with my hardware.
> I would say, as before :).
> Looking at the source code of single_release, this is very similar to what
> is done today.
>
> But yes, it would also be interesting to use single_open in the open()
> syscall.
> I think this would be nicer to use only single_*() functions.
>
> Maybe is it interesting to submit a patch that does a cleanup for all the
> i2c-dev file ? And not only the release function ?
Yes, that would be better. If you do that, please make sure to run your
patch through scripts/checkpatch.pl before sending it.
--
Jean Delvare
next prev parent reply other threads:[~2010-03-23 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 10:01 [PATCH]I2C device - release cleanup Jean-Michel Hautbois
[not found] ` <8cad0aa1003230301g44434763w13da24799f811faa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-23 12:54 ` Jean Delvare
[not found] ` <0016e6d64c23d0770e0482776d51@google.com>
[not found] ` <0016e6d64c23d0770e0482776d51-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2010-03-23 16:21 ` Jean Delvare [this message]
[not found] ` <0016e6d977228ec35704827c94c6@google.com>
[not found] ` <0016e6d977228ec35704827c94c6-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2010-03-24 13:16 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323172143.6b078b2e@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=jhautbois-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox