From: Jarkko Nikula <jhnikula@gmail.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Mika Westerberg <ext-mika.1.westerberg@nokia.com>,
linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org,
Cory Maccarrone <darkstar6262@gmail.com>
Subject: Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe
Date: Wed, 31 Mar 2010 15:27:00 +0300 [thread overview]
Message-ID: <20100331152700.17695375.jhnikula@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1003310427180.14436@utopia.booyaka.com>
On Wed, 31 Mar 2010 04:27:41 -0600 (MDT)
Paul Walmsley <paul@pwsan.com> wrote:
> > This patch moves register shift setting before any register accesses are done.
> >
> > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
> > Cc: Cory Maccarrone <darkstar6262@gmail.com>
>
> Tested-by: Paul Walmsley <paul@pwsan.com>
>
BTW, Tony had the same fix buried in an another thread:
http://marc.info/?l=linux-omap&m=126826012627677&w=2
You could add my tested by as well to which one goes in but the fix
should go for 2.6.34 as the mainline doesn't boot otherwise on OMAP.
Tested-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2010-03-31 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 10:12 [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe Mika Westerberg
2010-03-31 10:27 ` Paul Walmsley
2010-03-31 12:27 ` Jarkko Nikula [this message]
2010-04-16 9:47 ` Grazvydas Ignotas
[not found] ` <n2m6ed0b2681004160247o7cddd774sd199ea0eb51c9946-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-11 6:54 ` Jarkko Nikula
[not found] ` <20100511095407.cb44ef8d.jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-05-11 7:01 ` Mika Westerberg
[not found] ` <20100511070122.GE11783-etG4378wJBqLa08RA6KHbYwBHEhOmDVPtqGf+n4yE6E@public.gmane.org>
2010-05-11 7:19 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331152700.17695375.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=darkstar6262@gmail.com \
--cc=ext-mika.1.westerberg@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).