From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] power/ds2782: fix clientdata on removal Date: Thu, 1 Apr 2010 14:40:21 +0400 Message-ID: <20100401104021.GA30121@oksana.dev.rtsoft.ru> References: <1270117664-29099-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1270117664-29099-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ryan Mallon , Hans Verkuil , Jean Delvare List-Id: linux-i2c@vger.kernel.org On Thu, Apr 01, 2010 at 12:27:44PM +0200, Wolfram Sang wrote: > Probably due to a copy & paste bug, clientdata was set again to the data > structure (which is freed immediately afterwards) when it should be > NULLed. Just remove the calls as the i2c-core does this automatically > now. > > Signed-off-by: Wolfram Sang > Cc: Ryan Mallon > Cc: Hans Verkuil > Cc: Anton Vorontsov > Cc: Jean Delvare > --- > > Anton: If it is okay with you, I think this should go via the I2C-tree to > ensure it comes after the needed modification of the i2c-core. Sure thing. Acked-by: Anton Vorontsov Thanks!