[PATCH] drivers: i2c-gpio: move initialization code subsys_initcall()

[PATCH] drivers: i2c-gpio: move initialization code subsys_initcall()

[Marek Szyprowski]

GPIO driven I2C bus can be used for controlling the PMIC chip. The example
of such configuration is Samsung Aquila board.

This patch moves initialization code subsys_initcall() to ensure that the i2c
bus is available early so the regulators can be quicly probed and available for
other devices on their probe() call.

Such solution has been proposed by Mark Brown to fix the problem of the
regulators not beeing available on the peripheral device probe():
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-March/011971.html

CC: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Reviewed-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

---
 drivers/i2c/busses/i2c-gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index 32104ea..bb1a1a8 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -210,7 +210,7 @@ static int __init i2c_gpio_init(void)
 
 	return ret;
 }
-module_init(i2c_gpio_init);
+subsys_initcall(i2c_gpio_init);
 
 static void __exit i2c_gpio_exit(void)
 {
-- 
1.6.4

Re: [PATCH] drivers: i2c-gpio: move initialization code subsys_initcall()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Thu, Apr 01, 2010 at 03:43:19PM +0200, Marek Szyprowski wrote:
> GPIO driven I2C bus can be used for controlling the PMIC chip. The example
> of such configuration is Samsung Aquila board.
> 
> This patch moves initialization code subsys_initcall() to ensure that the i2c
> bus is available early so the regulators can be quicly probed and available for

Minor: quickly

> other devices on their probe() call.
> 
> Such solution has been proposed by Mark Brown to fix the problem of the
> regulators not beeing available on the peripheral device probe():
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-March/011971.html
> 
> CC: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> Reviewed-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Yup, a number of drivers do this:

Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] drivers: i2c-gpio: move initialization code subsys_initcall()

[Jean Delvare]

On Thu, 1 Apr 2010 15:49:18 +0200, Wolfram Sang wrote:
> On Thu, Apr 01, 2010 at 03:43:19PM +0200, Marek Szyprowski wrote:
> > GPIO driven I2C bus can be used for controlling the PMIC chip. The example
> > of such configuration is Samsung Aquila board.
> > 
> > This patch moves initialization code subsys_initcall() to ensure that the i2c
> > bus is available early so the regulators can be quicly probed and available for
> 
> Minor: quickly
> 
> > other devices on their probe() call.
> > 
> > Such solution has been proposed by Mark Brown to fix the problem of the
> > regulators not beeing available on the peripheral device probe():
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2010-March/011971.html
> > 
> > CC: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> > Reviewed-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 
> Yup, a number of drivers do this:
> 
> Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Applied, thanks. Is it desirable to have this patch in 2.6.34, or is
2.6.35 enough?

-- 
Jean Delvare

RE: [PATCH] drivers: i2c-gpio: move initialization code subsys_initcall()

[Marek Szyprowski]

Hello,

On Thursday, April 01, 2010 4:30 PM Jean Delvare wrote:

> On Thu, 1 Apr 2010 15:49:18 +0200, Wolfram Sang wrote:
> > On Thu, Apr 01, 2010 at 03:43:19PM +0200, Marek Szyprowski wrote:
> > > GPIO driven I2C bus can be used for controlling the PMIC chip. The example
> > > of such configuration is Samsung Aquila board.
> > >
> > > This patch moves initialization code subsys_initcall() to ensure that the i2c
> > > bus is available early so the regulators can be quicly probed and available for
> >
> > Minor: quickly
> >
> > > other devices on their probe() call.
> > >
> > > Such solution has been proposed by Mark Brown to fix the problem of the
> > > regulators not beeing available on the peripheral device probe():
> > > http://lists.infradead.org/pipermail/linux-arm-kernel/2010-March/011971.html
> > >
> > > CC: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> > > Reviewed-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > > Signed-off-by: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >
> > Yup, a number of drivers do this:
> >
> > Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> 
> Applied, thanks. Is it desirable to have this patch in 2.6.34, or is
> 2.6.35 enough?

2.6.35 would be enough. Thanks :)

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center