public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: remove_clientdata_to_null-branch
Date: Sat, 3 Apr 2010 20:27:17 +0200	[thread overview]
Message-ID: <20100403202717.66a0743f@hyperion.delvare> (raw)
In-Reply-To: <20100403182207.GC2190-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

On Sat, 3 Apr 2010 20:22:07 +0200, Wolfram Sang wrote:
> > I've seen it, but it is something for the power subsystem maintainer
> > (or akpm if there is none) to apply. I did kill drivers/i2c/chips for a
> > reason.
> 
> Oops, sorry my failure then. I asked Anton Vorontsov (power-maintainer) if he
> is fine with going this via the i2c-tree, so it will surely come after the
> needed modification of the core.

Both changes are independent. We all know that setting the driver data
back to NULL is cosmetic only, so nothing wrong will happen if we
don't. And the ds2782_battery fix is a no-op anyway (the code you're
removing did nothing.) Let's not invent patch dependencies where they
do not exist.

> That is why he "only" acked it. (I still think
> this sounds reasonable, the other cleaning-up patch should also go via i2c,
> right? Or am I missing something?)

I only pick patches in my i2c tree that touch other drivers if there is
a strong dependency between the changes. As this is not the case here,
I prefer the patch to go through the power subsystem tree.

-- 
Jean Delvare

      parent reply	other threads:[~2010-04-03 18:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-03 17:36 remove_clientdata_to_null-branch Wolfram Sang
     [not found] ` <20100403173646.GB2190-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-03 18:13   ` remove_clientdata_to_null-branch Jean Delvare
     [not found]     ` <20100403201317.1321b414-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-04-03 18:22       ` remove_clientdata_to_null-branch Wolfram Sang
     [not found]         ` <20100403182207.GC2190-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-03 18:27           ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100403202717.66a0743f@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox