linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Yegor Yefremov <yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: PCA9564: "bus is not idle" issue
Date: Tue, 6 Apr 2010 09:52:08 +0200	[thread overview]
Message-ID: <20100406075208.GA5102@pengutronix.de> (raw)
In-Reply-To: <j2pf69abfc31004060048z1b9500e1g9e12fb5bd794dc4a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

On Tue, Apr 06, 2010 at 09:48:49AM +0200, Yegor Yefremov wrote:
> >>> > > I'm using PCA9564 attached to a ks8695 SoC. During my efforts to get
> >>> > > 2.6.33/34 running on my system I noticed sporadic problems with RTC:
> >>> >
> >>> > [...]
> >>> >
> >>> > > static struct i2c_pca9564_pf_platform_data  __initdata pca_data ={
> >>> > >       .gpio = -1,
> >>> > >       .i2c_clock_speed = 59000,
> >>> > >       .timeout = 1,
> >>> > > };
> >>> >
> >>> > Commit 8e99ada8deaa9033600cd2c7d0a9366b0e99ab68 changed the timeout settings to
> >>> > jiffies. So, one jiffy as timeout will not work. Try 'HZ' here.
> >>>
> >>> So this means the bug isn't in the mainline kernel tree and I can
> >>> ignore it?
> >>
> >> A confirmation from Yegor would be nice, but his logs let me believe that
> >> this is really the cause.
> >>
> >>> As a side note, arch/blackfin/mach-bf561/boards/acvilon.c sets timeout
> >>> to 10000, so the actual timeout depends on the value of HZ, which is
> >>> probably not desirable. Not to mention that a timeout of over one
> >>> minute (worst case) doesn't seem too smart ;)
> >>
> >> There is also an i2c-gpio-user using non-HZ value. Will prepare patches.
> >
> > Thank for your solution. I'll try it on Tuesday and confirm ASAP.
> 
> Wolfram, do you mean so:
> 
> static struct i2c_pca9564_pf_platform_data  __initdata pca_data ={
>            .gpio = -1,
>            .i2c_clock_speed = 59000,
>            .timeout = HZ,
> };
> 
> I've tried this, but with the same result. The bus is still not idle.

That's bad news :(( Did you notice a difference in behaviour? There should be a
1 second delay now before the message arises...

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2010-04-06  7:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17 12:59 PCA9564: "bus is not idle" issue Yegor Yefremov
     [not found] ` <f69abfc31003170559y3c0a5a6fi91c1ae7692700c66-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-17 13:52   ` Wolfram Sang
     [not found]     ` <20100317135223.GD4153-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-17 15:26       ` Yegor Yefremov
     [not found]         ` <f69abfc31003170826j18fa0fddq1c46b8bcebf75c57-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-18  9:01           ` Yegor Yefremov
     [not found]             ` <f69abfc31003180201m5c5e167enf8256c4843e0c6ba-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-18  9:19               ` Wolfram Sang
     [not found]                 ` <20100318091917.GA27165-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-18  9:51                   ` Yegor Yefremov
     [not found]                     ` <f69abfc31003180251q53c96f8chc6b96d29c2ceec6d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-29 14:31                       ` Jean Delvare
     [not found]                         ` <20100329163149.41df7f10-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-30 13:16                           ` Yegor Yefremov
2010-04-03 16:29   ` Wolfram Sang
     [not found]     ` <20100403162939.GA2190-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-03 18:23       ` Jean Delvare
     [not found]         ` <20100403202329.3bdb407c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-04-04  3:29           ` Wolfram Sang
     [not found]             ` <20100404032929.GA12800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-04 11:00               ` Yegor Yefremov
     [not found]                 ` <t2zf69abfc31004040400wc3330285pe5d4602d31e0a52b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-06  7:48                   ` Yegor Yefremov
     [not found]                     ` <j2pf69abfc31004060048z1b9500e1g9e12fb5bd794dc4a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-06  7:52                       ` Wolfram Sang [this message]
     [not found]                         ` <20100406075208.GA5102-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-06  8:04                           ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100406075208.GA5102@pengutronix.de \
    --to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).