[PATCH] blackfin/acvilon: Fix timeout usage for I2C

[PATCH] blackfin/acvilon: Fix timeout usage for I2C

[Wolfram Sang]

The timeout value is in jiffies, so it should be using HZ, not a plain
number. As '10000' is ambiguous, 1HZ is used as conservative default.

Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: Valentin Yakovenkov <yakovenkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/blackfin/mach-bf561/boards/acvilon.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/blackfin/mach-bf561/boards/acvilon.c b/arch/blackfin/mach-bf561/boards/acvilon.c
index 5163e2c..bfcfa86 100644
--- a/arch/blackfin/mach-bf561/boards/acvilon.c
+++ b/arch/blackfin/mach-bf561/boards/acvilon.c
@@ -44,6 +44,7 @@
 #include <linux/spi/flash.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
+#include <linux/jiffies.h>
 #include <linux/i2c-pca-platform.h>
 #include <linux/delay.h>
 #include <linux/io.h>
@@ -112,7 +113,7 @@ static struct resource bfin_i2c_pca_resources[] = {
 struct i2c_pca9564_pf_platform_data pca9564_platform_data = {
 	.gpio = -1,
 	.i2c_clock_speed = 330000,
-	.timeout = 10000
+	.timeout = HZ,
 };
 
 /* PCA9564 I2C Bus driver */
-- 
1.7.0

Re: [PATCH] blackfin/acvilon: Fix timeout usage for I2C

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

On Sun, Apr 04, 2010 at 04:04:16PM +0200, Wolfram Sang wrote:
> The timeout value is in jiffies, so it should be using HZ, not a plain
> number. As '10000' is ambiguous, 1HZ is used as conservative default.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> Cc: Valentin Yakovenkov <yakovenkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/blackfin/mach-bf561/boards/acvilon.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/blackfin/mach-bf561/boards/acvilon.c b/arch/blackfin/mach-bf561/boards/acvilon.c
> index 5163e2c..bfcfa86 100644
> --- a/arch/blackfin/mach-bf561/boards/acvilon.c
> +++ b/arch/blackfin/mach-bf561/boards/acvilon.c
> @@ -44,6 +44,7 @@
>  #include <linux/spi/flash.h>
>  #include <linux/irq.h>
>  #include <linux/interrupt.h>
> +#include <linux/jiffies.h>
>  #include <linux/i2c-pca-platform.h>
>  #include <linux/delay.h>
>  #include <linux/io.h>
> @@ -112,7 +113,7 @@ static struct resource bfin_i2c_pca_resources[] = {
>  struct i2c_pca9564_pf_platform_data pca9564_platform_data = {
>  	.gpio = -1,
>  	.i2c_clock_speed = 330000,
> -	.timeout = 10000
> +	.timeout = HZ,
>  };
>  
>  /* PCA9564 I2C Bus driver */

Ping.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Uclinux-dist-devel] [PATCH] blackfin/acvilon: Fix timeout usage for I2C

[Mike Frysinger]

i'll pick this up for the next merge window (i.e. the one in a few
days) if Valentin has no feedback by then
-mike

Re: [Uclinux-dist-devel] [PATCH] blackfin/acvilon: Fix timeout usage for I2C

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

On Sun, May 09, 2010 at 10:39:24PM -0400, Mike Frysinger wrote:
> i'll pick this up for the next merge window (i.e. the one in a few
> days) if Valentin has no feedback by then

Thanks, this was the last board using a plain number. Case closed for now.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Uclinux-dist-devel] [PATCH] blackfin/acvilon: Fix timeout usage for I2C

[Valentin Yakovenkov]

10.05.2010 6:39, Mike Frysinger wrote:
> i'll pick this up for the next merge window (i.e. the one in a few
> days) if Valentin has no feedback by then

Sorry, it's so much business and emails, so i've just saw this messages.
It's ok.