From: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Shinya Kuribayashi
<shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [CORRECTED] I2C driver supporting Moorestown and Medfield platform
Date: Mon, 9 Aug 2010 12:07:43 +0100 [thread overview]
Message-ID: <20100809120743.05e22ef4@linux.intel.com> (raw)
In-Reply-To: <4C5F97AC.1020509-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> hardware/software resources, but IMO, MRST is not easy to imagine
> that it represents "Moorstone". But this is not such a big deal.
mrst is used all over the place - I'm not familiar with how that came
about originally.
> > + * Copyright (c) 2009 Intel Corporation.
> > + * Copyright (c) 2009 Synopsys. Inc.
>
> Having a quick glance of the patch, the driver is similar to the
> existing I2C_DESIGNWARE driver. Presumably Intel people have already
> checkekd the i2c-designware.c and made a decision that it would be
> reasonable to create a new I2C driver to incorporate its requirements
> (such as PCI resource handlings, power management code, etc.), rather
> than to extend the existing one. Is my understanding correct?
>
> I'm not objecting to the patch, but would like to know the background
> of this driver, as one of the DW users.
There are various little differences along with the PCI, power
management, timing and configuration side. I've also looked at the two
side by side and agreed with the original Intel authors that it seemed
best to keep it as two drivers. Otherwise you drag a lot of PCI and PCI
pm logic into a simpler driver that is used on non PCI platforms.
Alan
next prev parent reply other threads:[~2010-08-09 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 14:34 [CORRECTED] I2C driver supporting Moorestown and Medfield platform Alan Cox
[not found] ` <20100803143431.23655.31975.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-08-09 5:52 ` Shinya Kuribayashi
[not found] ` <4C5F97AC.1020509-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2010-08-09 11:07 ` Alan Cox [this message]
[not found] ` <20100809120743.05e22ef4-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-08-09 23:58 ` Shinya Kuribayashi
2010-08-09 10:59 ` Ben Dooks
[not found] ` <4C5FDFA9.60703-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
2010-08-09 12:23 ` Alan Cox
[not found] ` <20100809132345.44fdbaea-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-08-31 22:44 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809120743.05e22ef4@linux.intel.com \
--to=alan-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).