Re: [PATCH] i2c-omap: Make sure i2c bus is free before setting it to idle

Re: [PATCH] i2c-omap: Make sure i2c bus is free before setting it to idle

[Felipe Balbi]

Hi,

On Thu, Aug 26, 2010 at 09:36:44AM +0200, Nyman Mathias (Nokia-MS/Helsinki) wrote:
>If the i2c bus receives an interrupt with both BB (bus busy) and
>ARDY (register access ready) statuses set during the tranfer of the last message
>the bus was put to idle while still busy.
>
>This caused bus to timeout.
>
>Signed-off-by: Mathias Nyman <mathias.nyman@nokia.com>

adding linux-i2c and Ben Dooks to Cc list.

>---
> drivers/i2c/busses/i2c-omap.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>index 824ac1c..3271ce1 100644
>--- a/drivers/i2c/busses/i2c-omap.c
>+++ b/drivers/i2c/busses/i2c-omap.c
>@@ -602,6 +602,8 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>
> 	if (r == 0)
> 		r = num;
>+
>+	omap_i2c_wait_for_bb(dev);
> out:
> 	omap_i2c_idle(dev);
> 	return r;
>-- 
>1.5.6.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

DefectiveByDesign.org

Re: [PATCH] i2c-omap: Make sure i2c bus is free before setting it to idle

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [100826 00:34]:
> Hi,
> 
> On Thu, Aug 26, 2010 at 09:36:44AM +0200, Nyman Mathias (Nokia-MS/Helsinki) wrote:
> >If the i2c bus receives an interrupt with both BB (bus busy) and
> >ARDY (register access ready) statuses set during the tranfer of the last message
> >the bus was put to idle while still busy.
> >
> >This caused bus to timeout.
> >
> >Signed-off-by: Mathias Nyman <mathias.nyman@nokia.com>
> 
> adding linux-i2c and Ben Dooks to Cc list.

Ben, can you please take this? The patchwork.kernel.org link is:

http://patchwork.kernel.org/patch/133641/

Or let Mathias know if he should repost.

Acked-by: Tony Lindgren <tony@atomide.com>
 
> >---
> >drivers/i2c/busses/i2c-omap.c |    2 ++
> >1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> >index 824ac1c..3271ce1 100644
> >--- a/drivers/i2c/busses/i2c-omap.c
> >+++ b/drivers/i2c/busses/i2c-omap.c
> >@@ -602,6 +602,8 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
> >
> >	if (r == 0)
> >		r = num;
> >+
> >+	omap_i2c_wait_for_bb(dev);
> >out:
> >	omap_i2c_idle(dev);
> >	return r;
> >-- 
> >1.5.6.5
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> balbi
> 
> DefectiveByDesign.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c-omap: Make sure i2c bus is free before setting it to idle

[Ben Dooks]

On Thu, Sep 16, 2010 at 03:40:50PM -0700, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org> [100826 00:34]:
> > Hi,
> > 
> > On Thu, Aug 26, 2010 at 09:36:44AM +0200, Nyman Mathias (Nokia-MS/Helsinki) wrote:
> > >If the i2c bus receives an interrupt with both BB (bus busy) and
> > >ARDY (register access ready) statuses set during the tranfer of the last message
> > >the bus was put to idle while still busy.
> > >
> > >This caused bus to timeout.
> > >
> > >Signed-off-by: Mathias Nyman <mathias.nyman-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> > 
> > adding linux-i2c and Ben Dooks to Cc list.
> 
> Ben, can you please take this? The patchwork.kernel.org link is:

thanks, added to for-linus/2636-rc6-i2c

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.