From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH v3] power supply: add driver for TI BQ20Z75 gas gauge IC Date: Mon, 6 Sep 2010 11:41:01 +0400 Message-ID: <20100906074101.GA12253@oksana.dev.rtsoft.ru> References: <1283725883-22525-1-git-send-email-rklein@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1283725883-22525-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: RhylandKlein-IvAbHhfYiycN+BqQ9rBEUg@public.gmane.org Cc: broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rhyland Klein List-Id: linux-i2c@vger.kernel.org On Sun, Sep 05, 2010 at 03:31:23PM -0700, RhylandKlein-IvAbHhfYiycN+BqQ9rBEUg@public.gmane.org wrote: > From: Rhyland Klein > > this driver depends on I2C and uses SMBUS for communication with the host. > > Addressed comments from reviews by Mark Brown and Jean Delvare. > * Cleaned up whitespace and alignment issues > * changed return codes to more appropriate values > * change Kconfig option name to be consistent with existing devices > * removed global struct and moved to device specific data > * changed printk to dev_dbg > * added reviewed-by tags for Mark and Jean. > > Reviewed-by: Mark Brown > Reviewed-by: Jean Delvare > Signed-off-by: Rhyland Klein Applied, thanks everyone!