From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] i2c-omap: Make sure i2c bus is free before setting it to idle Date: Thu, 16 Sep 2010 15:40:50 -0700 Message-ID: <20100916224050.GU29610@atomide.com> References: <1282808204-1689-1-git-send-email-mathias.nyman@nokia.com> <20100826074118.GH23263@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100826074118.GH23263@nokia.com> Sender: linux-omap-owner@vger.kernel.org To: Felipe Balbi Cc: "Nyman Mathias (Nokia-MS/Helsinki)" , "linux-omap@vger.kernel.org" , linux-i2c@vger.kernel.org, ben-linux@fluff.org List-Id: linux-i2c@vger.kernel.org * Felipe Balbi [100826 00:34]: > Hi, > > On Thu, Aug 26, 2010 at 09:36:44AM +0200, Nyman Mathias (Nokia-MS/Helsinki) wrote: > >If the i2c bus receives an interrupt with both BB (bus busy) and > >ARDY (register access ready) statuses set during the tranfer of the last message > >the bus was put to idle while still busy. > > > >This caused bus to timeout. > > > >Signed-off-by: Mathias Nyman > > adding linux-i2c and Ben Dooks to Cc list. Ben, can you please take this? The patchwork.kernel.org link is: http://patchwork.kernel.org/patch/133641/ Or let Mathias know if he should repost. Acked-by: Tony Lindgren > >--- > >drivers/i2c/busses/i2c-omap.c | 2 ++ > >1 files changed, 2 insertions(+), 0 deletions(-) > > > >diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > >index 824ac1c..3271ce1 100644 > >--- a/drivers/i2c/busses/i2c-omap.c > >+++ b/drivers/i2c/busses/i2c-omap.c > >@@ -602,6 +602,8 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) > > > > if (r == 0) > > r = num; > >+ > >+ omap_i2c_wait_for_bb(dev); > >out: > > omap_i2c_idle(dev); > > return r; > >-- > >1.5.6.5 > > > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-omap" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > balbi > > DefectiveByDesign.org > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html