From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH RFC 1/1] MISC: Broadcom BCM4751 GPS driver Date: Mon, 27 Sep 2010 16:04:12 +0200 Message-ID: <20100927140412.GA3277@ucw.cz> References: <1282572026-14905-1-git-send-email-matti.j.aaltonen@nokia.com> <1282572026-14905-2-git-send-email-matti.j.aaltonen@nokia.com> <1283512047.26985.119.camel@masi.mnp.nokia.com> <20100910185942.GB17794@hexapodia.org> <1284372716.12913.25.camel@masi.mnp.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1284372716.12913.25.camel-U1ola594hmgZeDAa2SinrdBPR1lH4CV8@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Matti J. Aaltonen" Cc: ext Andy Isaacson , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "akpm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Mon 2010-09-13 13:11:56, Matti J. Aaltonen wrote: > On Fri, 2010-09-10 at 20:59 +0200, ext Andy Isaacson wrote: > > On Fri, Sep 03, 2010 at 02:07:27PM +0300, Matti J. Aaltonen wrote: > > > On Mon, 2010-08-23 at 16:00 +0200, Aaltonen Matti.J (Nokia-MS/Tampere) > > > wrote: > > > > Driver for Broadcom BCM4751 GPS chip. > > > > > > I sent this a while ago but didn't get any comments about the code. What > > > do you think should something be changed or is it ready to get accepted? > > > > It's unlikely to get merged if there's no public documentation of the > > protocol it exposes, and no free codebase using the interface. > > OK... I'll just mention once again that it's possible to get the > specification for free after signing a contract with Nokia. (See: And you can get review comments after signing contract with me. Andy said it nicely in the other mail. No undocumented kernel interfaces please. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html