Re: [PATCH] fix PCA waitforcompletion() return value

Wolfram Sang
2010-09-22T09:31:23Z

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On Wed, Sep 22, 2010 at 11:20:48AM +0200, Yegor Yefremov wrote:
> ret is still -1, if during the polling read_byte() returns at once
> with I2C_PCA_CON_SI set. So ret > 0 would lead *_waitforcompletion()
> to return 0, in spite of the proper behavior.
>
> The routine was rewritten, so that ret has always a proper value,
> before returning.
>
> Signed-off-by: Yegor Yefremov <yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Great! Jean, I think this is .36-relevant. Do you plan another
pull-request (hmm, there is still my clientdata-patch ;))? Should
probably go to stable, too.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]