From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCHv2 2/5] misc: update bhsfh driver to Kconfig and Makefile Date: Sat, 9 Oct 2010 16:43:17 -0700 Message-ID: <20101009164317.d05db9dc.rdunlap@xenotime.net> References: <1286545324-18506-1-git-send-email-samu.p.onkalo@nokia.com> <1286545324-18506-3-git-send-email-samu.p.onkalo@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1286545324-18506-3-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Samu Onkalo Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org, alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, 8 Oct 2010 16:42:01 +0300 Samu Onkalo wrote: > Compilation support for bhsfh driver > > Signed-off-by: Samu Onkalo > --- > drivers/misc/Kconfig | 10 ++++++++++ > drivers/misc/Makefile | 1 + > 2 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index b743312..f2e8065 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -314,6 +314,16 @@ config SENSORS_BH1780 > This driver can also be built as a module. If so, the module > will be called bh1780gli. > > +config SENSORS_BHSFH > + tristate "BH1770GLC / SFH7770 combined ALS / Proximity sensor"; Please drop the trailing ';'. It may work, but it's quite "different." > + depends on I2C > + ---help--- > + Say Y here if you want to build a driver for BH1770GLC / SFH7770 > + combined ambient light and proximity sensor chip end above sentence with period ('.'). > + > + To compile this driver as a module, choose M here: the > + module will be called bhsfh. If unsure, say N here. > + > config HMC6352 > tristate "Honeywell HMC6352 compass" > depends on I2C > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index 42eab95..fd5a4b7 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -16,6 +16,7 @@ obj-$(CONFIG_TIFM_CORE) += tifm_core.o > obj-$(CONFIG_TIFM_7XX1) += tifm_7xx1.o > obj-$(CONFIG_PHANTOM) += phantom.o > obj-$(CONFIG_SENSORS_BH1780) += bh1780gli.o > +obj-$(CONFIG_SENSORS_BHSFH) += bhsfh.o > obj-$(CONFIG_SGI_IOC4) += ioc4.o > obj-$(CONFIG_ENCLOSURE_SERVICES) += enclosure.o > obj-$(CONFIG_KGDB_TESTS) += kgdbts.o > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***