Re: [PATCHv2 2/5] misc: update bhsfh driver to Kconfig and Makefile

Jonathan Cameron
2010-10-11T13:36:46Z

On 10/11/10 07:17, Onkalo Samu wrote:
> On Fri, 2010-10-08 at 16:25 +0200, ext Jonathan Cameron wrote:
>> On 10/08/10 14:42, Samu Onkalo wrote:
>>> Compilation support for bhsfh driver
>>>
>>> Signed-off-by: Samu Onkalo <samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
>>> ---
>>> drivers/misc/Kconfig | 10 ++++++++++
>>> drivers/misc/Makefile | 1 +
>>> 2 files changed, 11 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
>>> index b743312..f2e8065 100644
>>> --- a/drivers/misc/Kconfig
>>> +++ b/drivers/misc/Kconfig
>>> @@ -314,6 +314,16 @@ config SENSORS_BH1780
>>> This driver can also be built as a module. If so, the module
>>> will be called bh1780gli.
>>>
>>> +config SENSORS_BHSFH
>>> + tristate "BH1770GLC / SFH7770 combined ALS / Proximity sensor";
>>> + depends on I2C
>>> + ---help---
>>> + Say Y here if you want to build a driver for BH1770GLC / SFH7770
>>> + combined ambient light and proximity sensor chip
>>> +
>>> + To compile this driver as a module, choose M here: the
>>> + module will be called bhsfh. If unsure, say N here.
>>> +
>> Really not keen on the naming. The above comment made me think this was
>> a single chip integrating both of the parts. Reading the code makes it clear
>> that they just share an interface. So please name it after one of them.
>> Lots of reasons not to invent combined names like this.
>> * non obvious thing to grep for.
>> * 3rd part comes along with a different name. Do you change the driver name?
>>
>> So best bet is always just to pick a supported part and name the driver after
>> that. The device table stuff and clear descriptions in kconfig will make
>> it obvious what the part supports.
>
> ok, bhsfh.* > bh1770glc.*
> What do you think, is it ok to still keep BHSFH in definitions and in
> function names?

I'd say it's fine to leave function names alone. If anyone else cares, they can
post a patch changing the lot.

Jonathan
>
>
>
>>> config HMC6352
>>> tristate "Honeywell HMC6352 compass"
>>> depends on I2C
>>> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
>>> index 42eab95..fd5a4b7 100644
>>> --- a/drivers/misc/Makefile
>>> +++ b/drivers/misc/Makefile
>>> @@ -16,6 +16,7 @@ obj-$(CONFIG_TIFM_CORE) += tifm_core.o
>>> obj-$(CONFIG_TIFM_7XX1) += tifm_7xx1.o
>>> obj-$(CONFIG_PHANTOM) += phantom.o
>>> obj-$(CONFIG_SENSORS_BH1780) += bh1780gli.o
>>> +obj-$(CONFIG_SENSORS_BHSFH) += bhsfh.o
>>> obj-$(CONFIG_SGI_IOC4) += ioc4.o
>>> obj-$(CONFIG_ENCLOSURE_SERVICES) += enclosure.o
>>> obj-$(CONFIG_KGDB_TESTS) += kgdbts.o
>>
>
>