public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	i2c list <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	al-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: skip address detection if provided in board_info
Date: Tue, 12 Oct 2010 11:01:40 -0700	[thread overview]
Message-ID: <20101012110140.00003391@unknown> (raw)
In-Reply-To: <20101012133425.490e3c4c-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>


>
>> So I still prefer the option of adding a flag, and leave the choice for
>> platform code whether to do the detect. If you agree, I would make a
>> cleaner patch.
>
>And I prefer that you set the class flag value in the platform data and
>have your i2c adapter driver read it. This is already supported and
>should work very fine without any change to i2c-core. I see no point in
>adding a global flag when we already have a much finer-grained setting
>available.
I agree that assigning the class code to adapter will solve our problem
but I do have a question/concern.

What if you have mixed devices under one adapter with some prefer to
have detect funtion some not. Then all detect functions will be ignored
if i2c adpater class code is 0. The granularity of information provided by
our FW is per i2c device.

Seems we have three cases:
1. adaptor class = 0, no detect
2. adaptor class !=0, FW provide address via board info, no detect
3. adaptor class !=0, no FW board info, do detect by default, but should
allow platform code override

I would think we need a global flag for case #3.

Thanks,

Jacob

  parent reply	other threads:[~2010-10-12 18:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 23:10 [PATCH] i2c: skip address detection if provided in board_info jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA
     [not found] ` <1286838635-16474-1-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-10-12  7:28   ` Jean Delvare
     [not found]     ` <20101012092822.6f4e4aa5-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-12  8:21       ` Feng Tang
2010-10-12  8:47         ` Jean Delvare
     [not found]           ` <20101012104707.3318511d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-12  9:30             ` Feng Tang
2010-10-12 11:34               ` Jean Delvare
     [not found]                 ` <20101012133425.490e3c4c-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-12 18:01                   ` Jacob Pan [this message]
2010-10-13  7:26                     ` Jean Delvare
     [not found]                       ` <20101013092654.7e26fa00-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-13 15:54                         ` Jacob Pan
2010-10-13 16:07                           ` Jean Delvare
     [not found]                             ` <20101013180751.2d37c513-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-13 17:01                               ` Jacob Pan
2010-10-13 17:04                   ` Feng Tang
2010-10-13  9:29                     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012110140.00003391@unknown \
    --to=jacob.jun.pan-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=al-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox