RE: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel

Heasley, Seth
2010-09-25T15:13:36Z

>> --- linux-2.6.35.4/drivers/i2c/busses/Kconfig.orig 2010-09-24
>14:59:23.000000000 -0700
>> +++ linux-2.6.35.4/drivers/i2c/busses/Kconfig 2010-09-24
>14:59:42.000000000 -0700
>> @@ -95,7 +95,7 @@
>> ESB2
>> ICH8
>> ICH9
>> - Tolapai
>> + EP80579
>> ICH10
>> 3400/5 Series (PCH)
>
>How did this become "5_3400_SERIES" in the symbol names? Shouldn't it
>be 3400_5_SERIES instead?

The way I did it here is consistent with the approved branding submitted for pci.ids. So perhaps changing the 3400/5 Series to "5 Series/3400 Series" would make sense.

>
>> Cougar Point (PCH)
>> --- linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c.orig 2010-09-24
>14:57:55.000000000 -0700
>> +++ linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c 2010-09-24
>14:59:13.000000000 -0700
>> @@ -38,7 +38,7 @@
>> 82801G (ICH7) 0x27da 32 hard yes yes
>yes
>> 82801H (ICH8) 0x283e 32 hard yes yes
>yes
>> 82801I (ICH9) 0x2930 32 hard yes yes
>yes
>> - Tolapai 0x5032 32 hard yes yes
>yes
>> + EP80579 0x5032 32 hard yes yes
>yes
>
>Maybe keep "Tolapai" inside parentheses, as people may know the
>platform by that name by now?

That'd be fine with me.

-Seth